Fix some comments

pull/120/head
Andre LaFleur 2021-12-18 15:11:07 -07:00
parent 4eef0c795a
commit af99c109de
3 changed files with 4 additions and 3 deletions

View File

@ -3,7 +3,6 @@
class DS3232 : public AbstractRTC { class DS3232 : public AbstractRTC {
public: public:
DS3232RTC rtc_ds; // TODO: We should not have public member variables
~DS3232() {} ~DS3232() {}
void config(String datetime); void config(String datetime);
void clearAlarm(); void clearAlarm();
@ -11,4 +10,6 @@ public:
void set(tmElements_t tm); void set(tmElements_t tm);
uint8_t temperature(); uint8_t temperature();
int rtcType(); int rtcType();
private:
DS3232RTC rtc_ds;
}; };

View File

@ -32,7 +32,7 @@ void PCF8563::read(tmElements_t &tm) {
tm.Month = rtc_pcf.getMonth(); tm.Month = rtc_pcf.getMonth();
if (tm.Month == 0){ //PCF8563 POR sets month = 0 for some reason if (tm.Month == 0){ //PCF8563 POR sets month = 0 for some reason
tm.Month = 1; tm.Month = 1;
tm.Year = 21; // TODO: I feel nervous about this--it's only 21 for a year, right? tm.Year = 21;
} else { } else {
tm.Year = rtc_pcf.getYear(); tm.Year = rtc_pcf.getYear();
} }

View File

@ -3,7 +3,6 @@
class PCF8563 : public AbstractRTC { class PCF8563 : public AbstractRTC {
public: public:
Rtc_Pcf8563 rtc_pcf; // TODO: We should not have public member variables
~PCF8563() {} ~PCF8563() {}
void config(String datetime); void config(String datetime);
void clearAlarm(); void clearAlarm();
@ -11,5 +10,6 @@ public:
void set(tmElements_t tm); void set(tmElements_t tm);
int rtcType(); int rtcType();
private: private:
Rtc_Pcf8563 rtc_pcf;
int getDayOfWeek(int d, int m, int y); int getDayOfWeek(int d, int m, int y);
}; };