From af99c109de6dfa9adc409e6d4e6dabb57face61d Mon Sep 17 00:00:00 2001 From: Andre LaFleur Date: Sat, 18 Dec 2021 15:11:07 -0700 Subject: [PATCH] Fix some comments --- src/DS3232.h | 3 ++- src/PCF8563.cpp | 2 +- src/PCF8563.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/DS3232.h b/src/DS3232.h index 631b37d..344fb6b 100644 --- a/src/DS3232.h +++ b/src/DS3232.h @@ -3,7 +3,6 @@ class DS3232 : public AbstractRTC { public: - DS3232RTC rtc_ds; // TODO: We should not have public member variables ~DS3232() {} void config(String datetime); void clearAlarm(); @@ -11,4 +10,6 @@ public: void set(tmElements_t tm); uint8_t temperature(); int rtcType(); +private: + DS3232RTC rtc_ds; }; \ No newline at end of file diff --git a/src/PCF8563.cpp b/src/PCF8563.cpp index 2027d4a..da1314b 100644 --- a/src/PCF8563.cpp +++ b/src/PCF8563.cpp @@ -32,7 +32,7 @@ void PCF8563::read(tmElements_t &tm) { tm.Month = rtc_pcf.getMonth(); if (tm.Month == 0){ //PCF8563 POR sets month = 0 for some reason tm.Month = 1; - tm.Year = 21; // TODO: I feel nervous about this--it's only 21 for a year, right? + tm.Year = 21; } else { tm.Year = rtc_pcf.getYear(); } diff --git a/src/PCF8563.h b/src/PCF8563.h index d5439f8..00ab200 100644 --- a/src/PCF8563.h +++ b/src/PCF8563.h @@ -3,7 +3,6 @@ class PCF8563 : public AbstractRTC { public: - Rtc_Pcf8563 rtc_pcf; // TODO: We should not have public member variables ~PCF8563() {} void config(String datetime); void clearAlarm(); @@ -11,5 +10,6 @@ public: void set(tmElements_t tm); int rtcType(); private: + Rtc_Pcf8563 rtc_pcf; int getDayOfWeek(int d, int m, int y); };